test: e2e coverage for nwc settings and service lifecycle

e2e/specs/backup-security.spec.ts

@@ -17,7 +17,7 @@ test.describe('Backup page', () => {
     await createFreshWallet(page);
 
     await page.getByRole('button', { name: 'Settings' }).click();
-    await page.getByRole('button', { name: 'Backup' }).click();
+    await page.getByRole('button', { name: 'Backup', exact: true }).click();
     await expect(page).toHaveURL(/#\/settings\/backup$/);
 
     // the honest recovery-phrase state: sattle never stores it

e2e/specs/nwc.spec.ts

@@ -0,0 +1,148 @@
+import { test, expect } from '../fixtures';
+import { createFreshWallet } from '../helpers/wallet';
+
+// M5 Nostr Wallet Connect settings surface. No real relay traffic: the one
+// test that runs the service injects a fake transport through the dev-only
+// window hook (stores/nwc.ts) before enabling - every other test stays
+// UI-only with the service off.
+
+type FakeSub = { closed: boolean; close: () => void };
+
+declare global {
+  interface Window {
+    __sattleNwcTest: { setTransport: (transport: unknown) => void };
+    __nwcSubs: FakeSub[];
+  }
+}
+
+const openNwcPage = async (page: import('@playwright/test').Page) => {
+  await page.goto('/#/settings/nwc');
+};
+
+test.describe('NWC settings page', () => {
+  test('renders the foreground-only explainer and the Connections settings entries link out', async ({
+    page,
+  }) => {
+    await createFreshWallet(page);
+
+    await page.getByRole('button', { name: 'Settings' }).click();
+    await page.getByRole('button', { name: 'Nostr Wallet Connect' }).click();
+    await expect(page).toHaveURL(/#\/settings\/nwc$/);
+
+    // the honest foreground-only explanation, not a feature promise
+    await expect(page.getByText('How this works', { exact: true })).toBeVisible();
+    await expect(
+      page.getByText('only while it is open and unlocked', { exact: false }),
+    ).toBeVisible();
+    await expect(page.getByText('dropped if they are more than ten minutes old')).toBeVisible();
+
+    // service off by default, toggle offered
+    await expect(page.locator('.q-toggle[aria-label="Enable Nostr Wallet Connect"]')).toBeVisible();
+    await expect(page.locator('[data-nwc-status]')).toHaveCount(0);
+
+    // empty connection list + create form with default relays
+    await expect(page.getByText('No connections yet')).toBeVisible();
+    await expect(page.getByText('wss://relay.damus.io')).toBeVisible();
+
+    // the second Connections entry lands on the backup page's relay management
+    await page.getByRole('button', { name: 'Back' }).click();
+    await page.getByRole('button', { name: 'Nostr backup & relays' }).click();
+    await expect(page).toHaveURL(/#\/settings\/backup$/);
+    await expect(page.getByText('Nostr backup', { exact: true })).toBeVisible();
+  });
+
+  test('creating a connection shows the connection string once, and never again', async ({
+    page,
+  }) => {
+    await createFreshWallet(page);
+    await openNwcPage(page);
+
+    await page.getByRole('button', { name: 'Create connection' }).click();
+
+    // the one-time reveal: warning, QR, copy button, and the string itself
+    await expect(page.getByText('shown only once', { exact: false })).toBeVisible();
+    const uri = (await page.locator('.nwc-connection-string').textContent())?.trim();
+    expect(uri).toBeTruthy();
+
+    // a well-formed NIP-47 connection string
+    const url = new URL(uri!);
+    expect(url.protocol).toBe('nostr+walletconnect:');
+    expect(url.host).toMatch(/^[0-9a-f]{64}$/);
+    expect(url.searchParams.get('secret')).toMatch(/^[0-9a-f]{64}$/);
+    const relays = url.searchParams.getAll('relay');
+    expect(relays.length).toBeGreaterThan(0);
+    expect(relays).toContain('wss://relay.damus.io');
+
+    // the connection joined the list, WITHOUT the string
+    await expect(page.locator('.q-item', { hasText: 'Client ' }).first()).toBeVisible();
+
+    // dismiss, leave and return: the string is gone for good
+    await page.getByRole('button', { name: "Done - I've saved it" }).click();
+    await expect(page.locator('.nwc-connection-string')).toHaveCount(0);
+    await page.goto('/#/settings');
+    await openNwcPage(page);
+    await expect(page.locator('.q-item', { hasText: 'Client ' }).first()).toBeVisible();
+    await expect(page.locator('.nwc-connection-string')).toHaveCount(0);
+    await expect(page.getByText('nostr+walletconnect://')).toHaveCount(0);
+  });
+
+  test('editing a connection budget persists across a reload', async ({ page }) => {
+    await createFreshWallet(page);
+    await openNwcPage(page);
+    await page.getByRole('button', { name: 'Create connection' }).click();
+    await page.getByRole('button', { name: "Done - I've saved it" }).click();
+
+    // the default budget, then edit it
+    const item = page.locator('.q-item', { hasText: 'Client' });
+    await expect(item.getByText('10,000 sats per day')).toBeVisible();
+    await item.getByRole('button', { name: 'Edit budget' }).click();
+    const dialog = page.locator('.q-dialog');
+    await dialog.getByText('100,000 sats per day', { exact: true }).click();
+    await dialog.getByRole('button', { name: 'Save' }).click();
+
+    await expect(item.getByText('100,000 sats per day')).toBeVisible();
+
+    await page.reload();
+    await expect(
+      page.locator('.q-item', { hasText: 'Client' }).getByText('100,000 sats per day'),
+    ).toBeVisible();
+  });
+
+  test('disabling the service stops every relay subscription', async ({ page }) => {
+    await createFreshWallet(page);
+    await openNwcPage(page);
+
+    // fake transport BEFORE enabling: no real WebSocket, and closable subs
+    await page.evaluate(() => {
+      window.__nwcSubs = [];
+      window.__sattleNwcTest.setTransport({
+        publish: () => Promise.resolve(),
+        subscribe: () => {
+          const sub: FakeSub = {
+            closed: false,
+            close() {
+              this.closed = true;
+            },
+          };
+          window.__nwcSubs.push(sub);
+          return sub;
+        },
+      });
+    });
+
+    // a connection to serve, then enable
+    await page.getByRole('button', { name: 'Create connection' }).click();
+    await page.getByRole('button', { name: "Done - I've saved it" }).click();
+    await page.locator('.q-toggle[aria-label="Enable Nostr Wallet Connect"]').click();
+
+    await expect(page.getByText('Service running', { exact: false })).toBeVisible();
+    await expect.poll(async () => page.evaluate(() => window.__nwcSubs.length)).toBeGreaterThan(0);
+
+    // disable: the status disappears and every subscription is closed
+    await page.locator('.q-toggle[aria-label="Enable Nostr Wallet Connect"]').click();
+    await expect(page.locator('[data-nwc-status]')).toHaveCount(0);
+    await expect
+      .poll(async () => page.evaluate(() => window.__nwcSubs.every((sub) => sub.closed)))
+      .toBe(true);
+  });
+});